Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: major API and routing changes #60

Merged
merged 23 commits into from
Nov 22, 2024
Merged

feat!: major API and routing changes #60

merged 23 commits into from
Nov 22, 2024

Conversation

AlexCLeduc
Copy link
Collaborator

@AlexCLeduc AlexCLeduc commented Oct 8, 2024

Working towards #58, won't get everything done,

Definitely will get done:

  • Add a ton of tests
  • Decouple classes from names and routes
  • Allow request access in search/get items
  • split up get_items into search and get_values_for_keys
  • Add authorization hook
  • Update translations
    • supports string substitution e.g. showing %(x)s of %(y)s
  • Better pagination?
    • better message (e.g. showing x of y)
    • encouraged use of max results
    • efficient slicing/counting of querysets
  • Update docs

Less certain about getting these this release...

  • Exposing a cleaner JS API
  • An API to augment hx-vals/params to include other things on the request
    • i.e. allow the search function to take into account other form fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant