Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with ancestry aggregation & scaling on biobank-data #19

Merged
merged 13 commits into from
Jun 12, 2024
Merged

Conversation

smlmbrt
Copy link
Member

@smlmbrt smlmbrt commented May 26, 2024

No description provided.

@smlmbrt smlmbrt linked an issue May 26, 2024 that may be closed by this pull request
@smlmbrt smlmbrt requested a review from nebfield May 26, 2024 12:02
@smlmbrt
Copy link
Member Author

smlmbrt commented May 26, 2024

Test should pass once pgscatalog.calc is published and tests are re-run.

nebfield added 3 commits June 5, 2024 11:44
* drop pyarrow support, it doesn't scale well, and be more consistent about public path properties

* refactor to use polars for reading and writing IPC files to improve scalability

* fix map_elements deprecation warning

* update lockfiles

* fix weird path -> is_path refactor that broke this test

* missed one >_>
@smlmbrt smlmbrt changed the title Fix problems with ancestry aggregation Fix problems with ancestry aggregation & scaling on biobank-data Jun 5, 2024
@nebfield nebfield linked an issue Jun 7, 2024 that may be closed by this pull request
nebfield added 3 commits June 7, 2024 21:02
* export key functions for sorting chromosomes / effect types

* use new key functions for sorting

* reduce memory usage during aggregation

* fix doctest output

* make aggregation steps clearer
@nebfield nebfield merged commit cd027b3 into main Jun 12, 2024
11 checks passed
@nebfield nebfield deleted the dev branch June 13, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate weird pgscatalog.core.lib.pgsexceptions.MatchRateError Ancestry analysis is adjusting AVGs
2 participants