-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Pyodide metadata and scores validators #395
Conversation
Q: is it missing pyodide in |
Pyodide can't be imported through python packages but needs to be imported in JS. The pypi page says:
It is imported in webworker.js: |
if (data.error) { | ||
let report = '<h5 class="mt-4"><i class="fa fa-times-circle pgs_color_red"></i> Error report</h5>' | ||
+ makeReportTable(data.error, 'Error message(s)'); | ||
$('#report_error').html(report); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be overkilling, but wondering if we should have a function for these html reports
, with the type of report and the message as arguments, e.g.:
function reports_html(type,msg) {
$('#report_'+type).html(msg);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this refactoring would make the code a bit confusing
No description provided.