Adding support for Kong 0.12. Upgrading version to 3.1.0 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGBI
requested changes
Jan 27, 2018
README.md
Outdated
| |-----------|------------------------------|--------------| | ||
| | 1.x.x | 0.6.x, 0.7.x, 0.8.x, 0.9.x | | | ||
| | 2.x.x | 0.10.x | | | ||
| | 3.x.x | 0.9.x, 0.10.x, 0.11.x, 0.12.x| >= 6.0.0 | |
There was a problem hiding this comment.
3.0.x should have it's own row because it will never be compatible with Kong 0.12.
| 3.0.x | 0.9.x, 0.10.x, 0.11.x | >= 6.0.0 |
| 3.x.x | 0.9.x, 0.10.x, 0.11.x, 0.12.x | >= 6.0.0 |
src/js/controllers/targets.js
Outdated
| // For Kong versions other than 0.12 | ||
| if ($scope.active) { | ||
| page += "/active"; | ||
| } |
There was a problem hiding this comment.
Problem with this logic is that when a new minor version of Kong will be available, kong dashboard will use the /active endpoint back again. I doubt that Kong 0.13 will go back to Kong 0.11 behavior for this endpoint.
How about this kind of logic?
if (["0.9.", "0.10", "0.11"].includes(env.kong_version.substring(0,4)) {
page += $scope.active ? "/active" : "";
} else {
page += !$scope.active ? "/all" : "";
}
There was a problem hiding this comment.
Okay. Make sense.
|
@PGBI I have updated the code based on your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @PGBI ,
As per the discussion #148, I have created a new pull request to add support for Kong 0.12.
Please review and let me know if this change can be merged.
I ran all the tests and they passed.
Best,
Peeyush