-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new trigger link mapping file for updated backend #485
Add new trigger link mapping file for updated backend #485
Conversation
If possible it would be good to now use the number of input links (here, 120) in the file name, since now there will be several different scenarios |
Hi @jbsauvan, the pull request is still in progress, but are the implemented changes as you might have expected for the scintillator? |
L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp3.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp3.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp3.cc
Outdated
Show resolved
Hide resolved
Quickly looking at https://github.com/snwebb/hgcal-linkmapping/blob/master/fluctuation.py#L119-L161, it seems indeed to correspond to what is needed. |
thanks @jbsauvan, the comments have been implemented |
Thanks @snwebb [1]
|
Hi @jbsauvan, the tester now runs without errors. I corrected the scintillator geometry and also found a bug in the stage 2 to stage 1 links, which is now also corrected. |
PR description:
Add new trigger link mapping file for the updated backend layout of 14 Stage 1 FPGAs per 120º sector.