forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting and Truncation Module for the Emulator #483
Merged
jbsauvan
merged 19 commits into
PFCal-dev:hgc-tpg-devel-CMSSW_12_0_0_pre3
from
snwebb:SW-Truncation-July
Aug 18, 2021
Merged
Sorting and Truncation Module for the Emulator #483
jbsauvan
merged 19 commits into
PFCal-dev:hgc-tpg-devel-CMSSW_12_0_0_pre3
from
snwebb:SW-Truncation-July
Aug 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @snwebb |
jbsauvan
reviewed
Jul 23, 2021
L1Trigger/L1THGCal/interface/backend/HGCalSortingTruncationConfig_SA.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/interface/backend/HGCalSortingTruncationImpl_SA.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/interface/backend/HGCalSortingTruncationConfig_SA.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/interface/backend/HGCalSortingTruncationImpl_SA.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/interface/backend/HGCalSortingTruncationImpl_SA.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/backend/HGCalSortingTruncationWrapper.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/backend/HGCalSortingTruncationWrapper.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/backend/HGCalSortingTruncationWrapper.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/src/backend/HGCalSortingTruncationImpl_SA.cc
Outdated
Show resolved
Hide resolved
Thanks @jbsauvan for the comments, which have now been implemented |
Thanks - I've removed the changes there. |
jbsauvan
reviewed
Jul 28, 2021
L1Trigger/L1THGCal/interface/backend/HGCalSortingTruncationImpl_SA.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/backend/HGCalSortingTruncationWrapper.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1THGCal/plugins/backend/HGCalSortingTruncationWrapper.cc
Outdated
Show resolved
Hide resolved
Thanks @jbsauvan, I've made these small changes. |
This was referenced Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Add the sorting and truncation module and associated wrappers and configs for the HGCal TPG emulator.
PR validation:
Compiles and runs without errors.