Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and Truncation Module for the Emulator #483

Merged

Conversation

snwebb
Copy link

@snwebb snwebb commented Jul 2, 2021

PR description:

Add the sorting and truncation module and associated wrappers and configs for the HGCal TPG emulator.

PR validation:

Compiles and runs without errors.

@jbsauvan
Copy link

Hi @snwebb
I see what looks like a bugfix in the geometry. If this is indeed a fix in the geometry not related to the Stage 2 sorting and truncation, could you make a separate PR with this fix?
Thanks

@snwebb
Copy link
Author

snwebb commented Jul 20, 2021

Hi @snwebb
I see what looks like a bugfix in the geometry. If this is indeed a fix in the geometry not related to the Stage 2 sorting and truncation, could you make a separate PR with this fix?
Thanks

Hi @jbsauvan yes I'll do that now.

@snwebb snwebb marked this pull request as ready for review July 20, 2021 15:44
@snwebb
Copy link
Author

snwebb commented Jul 23, 2021

Thanks @jbsauvan for the comments, which have now been implemented

@jbsauvan
Copy link

Thanks @snwebb
Concerning the trigger ids, I actually took care already of updating the geometry class here: b308cbb

@snwebb
Copy link
Author

snwebb commented Jul 28, 2021

Thanks - I've removed the changes there.

@snwebb
Copy link
Author

snwebb commented Aug 2, 2021

Thanks @jbsauvan, I've made these small changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants