fix: fix mapping ipv6-based port mappings

PDMLab · May 11, 2021 · 21b63cb · 21b63cb
1 parent 48c9f08
commit 21b63cb
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 21 deletions.
diff --git a/src/port-mapper.ts b/src/port-mapper.ts
@@ -4,26 +4,35 @@ const mapPorts = (
   mapped?: { address: string; port: number }
   exposed: { port: number; protocol: string }
 }> => {
-  const result = !ports
-    ? []
-    : (() => {
-        return ports.split(',').map((untypedPort) => {
-          const exposedFragments = untypedPort.trim().split('->')
+  if (!ports) {
+    return []
+  }
 
-          const [port, protocol] =
-            exposedFragments.length === 1
-              ? exposedFragments[0].split('/')
-              : exposedFragments[1].split('/')
-          const [address, mappedPort] =
-            exposedFragments.length === 2 ? exposedFragments[0].split(':') : []
-          return {
-            exposed: { port: Number(port), protocol },
-            ...(address &&
-              mappedPort && { mapped: { port: Number(mappedPort), address } })
-          }
-        })
-      })()
-  return result
+  return ports.split(',').map((untypedPort) => {
+    const exposedFragments = untypedPort.trim().split('->')
+
+    const [port, protocol] =
+      exposedFragments.length === 1
+        ? exposedFragments[0].split('/')
+        : exposedFragments[1].split('/')
+
+    const mapped = exposedFragments[0]
+    const lastDoubleColon = mapped.lastIndexOf(':')
+
+    if (lastDoubleColon === -1) {
+      return {
+        exposed: { port: Number(port), protocol },
+      }
+    }
+
+    const address = mapped.substr(0, lastDoubleColon)
+    const mappedPort = mapped.substr(lastDoubleColon + 1)
+
+    return {
+      exposed: { port: Number(port), protocol },
+      mapped: { port: Number(mappedPort), address },
+    }
+  })
 }
 
 export default mapPorts
diff --git a/test/port-mapper.test.ts b/test/port-mapper.test.ts
@@ -44,15 +44,15 @@ test('map multiple tcp ports exposed on ipv4 and ipv6 interfaces', () => {
     },
     {
       exposed: { port: 443, protocol: 'tcp' },
-      mapped: { address: ':::', port: 443 }
+      mapped: { address: '::', port: 443 }
     },
     {
       exposed: { port: 80, protocol: 'tcp' },
       mapped: { address: '0.0.0.0', port: 80 }
     },
     {
       exposed: { port: 80, protocol: 'tcp' },
-      mapped: { address: ':::', port: 80 }
+      mapped: { address: '::', port: 80 }
     }
   ])
 })