Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared GitHub Actions #28

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Use shared GitHub Actions #28

merged 1 commit into from
Sep 1, 2021

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Sep 1, 2021

Uses the shared actions introduced by PDLPorters/devops#8.

@coveralls
Copy link

coveralls commented Sep 1, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-2.4%) to 53.693% when pulling cbb0167 on gha-shared-actions into 551cb63 on master.

@zmughal zmughal requested a review from mohawk2 September 1, 2021 04:32
mohawk2
mohawk2 requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@mohawk2 mohawk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the gremlin with the wrong repo-name being checked for notifications, this is great! That will need tweaking, but once you're happy, I'm pleased for you to merge. Thanks!

The "fail" on CI is just the coverage which can be ignored.

@zmughal
Use shared GitHub Actions
cbb0167 
Uses the shared actions introduced by <PDLPorters/devops#8>.

- This build splits the targets to setup Perl first so that PDL's Perl
  deps can be installed.
- Remove need to specify repo for IRC notifications. Connects with
  <PDLPorters/devops#10>.
@zmughal zmughal merged commit 00f4608 into master Sep 1, 2021
@zmughal zmughal deleted the gha-shared-actions branch September 1, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohawk2 mohawk2 mohawk2 requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmughal @coveralls @mohawk2