-
Notifications
You must be signed in to change notification settings - Fork 36
CMIP7 requirements test #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a_specs_version from CV if present
…tributes in the CV
… in CMIP7_CV.json
durack1
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauzey1 looks great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to enable CMOR to write CMIP7 datasets.
branding_suffix
of variables will be tested against thebranding_suffix
template provided by the CV. Its componentstemporal_label
,vertical_label
,horizontal_label
, andarea_label
will have their values validated by their corresponding sections in the CV.mip_era
anddata_specs_version
will be set from the CV.frequency
can be defined in the user input JSON or by callingcmor_set_cur_dataset_attribute
prior to creating the time axis and variable that uses the axis.region
can be defined in the user input JSON or by callingcmor_set_cur_dataset_attribute
prior to callingcmor_write
.type
,positive
,valid_max
,valid_min
,ok_max_mean_abs
, andok_min_mean_abs
are now acquired from the header of tables and used as the default for a table's variable entries.variable_title
andbrand_description
can now be variable attributes if defined in the variable entry._cmip7_option
should be set in the user input JSON to enable CMIP7 global attribute checking similar to CMIP6 but without subexperiment tests.parent_mip_era
will be set toCMIP7
for all datasets that are written with_cmip7_option
set.data_archive_id
has been changed toarchive_id
in the CV.host_collection
has been added to theexperiment_id
entries of the CV.