Consistency fix for grid methods with no grid

subsitute_cell_names column_indices generic fallbacks include no grid case (grid == nothing)
PALEOtoolkit · Jan 5, 2025 · 00c96d6 · 00c96d6
1 parent fb92d7b
commit 00c96d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/CoordsDims.jl b/src/CoordsDims.jl
@@ -50,7 +50,7 @@ PALEO convention is that where possible `coordinates` contains:
 function set_coordinates! end
 
 """
-    function get_coordinates(obj, dimname) -> coordinates::Vector{String}
+    function get_coordinates(obj, dimname) -> coordinates::Vector
 
 Get coordinates (if any) attached to `dimname` for PALEO object `obj`
 

diff --git a/src/Grids.jl b/src/Grids.jl
@@ -321,12 +321,12 @@ function _show_subdomains_dimensions_coordinates(io, grid::PB.AbstractMesh)
 end
 
 # generic fallback for named cells 
-substitute_cell_names(grid::PB.AbstractMesh, cells) = cells
-substitute_cell_names(grid::PB.AbstractMesh, cells::Union{Number, Symbol}) =
+substitute_cell_names(grid::PB.AbstractMeshOrNothing, cells) = cells
+substitute_cell_names(grid::PB.AbstractMeshOrNothing, cells::Union{Number, Symbol}) =
     substitute_cell_names(grid, [cells])[]
 
 # generic fallback for column indices
-function column_indices(grid::PB.AbstractMesh, column)
+function column_indices(grid::PB.AbstractMeshOrNothing, column)
     throw(ArgumentError("grid $grid does not support column selection"))
 end