Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spread device capabilities view into all screens #89

Conversation

mykhailodanilenko
Copy link
Contributor

@mykhailodanilenko mykhailodanilenko commented Jun 25, 2024

🚀 Description

This PR adds the "device capabilities" view from #70 to screens other than video view. If using Android, the view will show "Android Native" until we start video playback and can reliably tell if it's ExoPlayer or MediaPlayer.
See deployed at https://mykhailodanilenko.github.io/web-client/

📄 Motivation and Context

#82

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist (copied from README)

  • Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
  • Reference the GitHub issue that you are contributing on in your commit title or body
  • Sign your commits, as this is required by the automated GitHub PR checks
  • Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
  • Include links and illustrations in your pull request to make it easy to review
  • Request a review by @ar9708, @OGTor, @tryklick and @mblomdahl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants