Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video player #122

Conversation

mykhailodanilenko
Copy link
Contributor

@mykhailodanilenko mykhailodanilenko commented Aug 2, 2024

🚀 Description

This PR adds video playback design implementation. As described in Figma.
https://mykhailodanilenko.github.io/web-client see deployed here

📄 Motivation and Context

#118

🧪 How Has This Been Tested?

Tested on web for desktop, android and ios, also as an app on android and in expo go in iOS.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist (copied from README)

  • Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
  • Reference the GitHub issue that you are contributing on in your commit title or body
  • Sign your commits, as this is required by the automated GitHub PR checks
  • Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
  • Include links and illustrations in your pull request to make it easy to review
  • Request a review by @mykhailodanilenko, @ar9708 and @mblomdahl

@mykhailodanilenko mykhailodanilenko self-assigned this Aug 2, 2024
@mykhailodanilenko mykhailodanilenko force-pushed the feature/video-controls-overlay-UI-impl branch 2 times, most recently from 2a09104 to cef7f25 Compare August 3, 2024 21:16
@mykhailodanilenko mykhailodanilenko force-pushed the feature/video-controls-overlay-UI-impl branch from cef7f25 to c468da1 Compare August 3, 2024 22:31
@ar9708 ar9708 requested a review from okaziya August 5, 2024 06:17
@mblomdahl mblomdahl added the enhancement New feature or request label Aug 7, 2024
@mykhailodanilenko mykhailodanilenko removed the enhancement New feature or request label Aug 7, 2024
@mykhailodanilenko mykhailodanilenko merged commit 0e59180 into OwnTube-tv:main Aug 7, 2024
@mblomdahl mblomdahl added 2nd review queue Scheduled for "2nd opinion" review enhancement New feature or request labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd review queue Scheduled for "2nd opinion" review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants