Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state for videos and pages #156

Closed
mykhailodanilenko opened this issue Sep 12, 2024 · 4 comments
Closed

Empty state for videos and pages #156

mykhailodanilenko opened this issue Sep 12, 2024 · 4 comments
Assignees
Labels
figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs

Comments

@mykhailodanilenko
Copy link
Contributor

Blocks of videos and pages need to have an "empty" state to indicate that there is no error but the data list is empty (length === 0)

@mykhailodanilenko
Copy link
Contributor Author

@mkl-adsn can you share your insight on how this kind of element should look? meaning an empty state for a channel/category/playlist or a whole page like history or playlists or channels (currently we are just showing plain text info like "View history is empty")

@mykhailodanilenko mykhailodanilenko added the figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs label Sep 18, 2024
@mkl-adsn
Copy link

If possible, I believe empty categories and playlist sections should be hidden altogether as they otherwise just clutter the site. For the other cases I think a plain text message similar to the error messages will suffice as empty channels and view histories in most cases should be a temporary problem.

Figma: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=908-11802&t=KYlUj6pngVhB0APk-1

@mkl-adsn
Copy link

Empty version of collection pages:

Channels page
History page
Playlists page
Categories page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs
Projects
Development

No branches or pull requests

2 participants