build: Update actions/setup-node to v4 #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this to draft. Not sure why the types aren't aligning, since the versions match up, and don't have more time to debug this weekend. |
valarnin
force-pushed
the
update-node20
branch
from
7976b00 to
b8226fa
Compare
valarnin
force-pushed
the
update-node20
branch
from
b8226fa to
a452d7b
Compare
valarnin
changed the title
|
The scope of this PR has changed, as the node version reference was updated with the update to typescript 5.1. As such, this is now a simple actions version bump and is ready for review/merge. |
github-actions
bot
added
the
auto-merge
MaikoTan
approved these changes
Dec 6, 2024
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the typedef for node to v20, andupdate the action.yml file to use setup-node@v4 which bumps its own dependencies to use node v20.This fixes a warning during action builds, as well as aligning type hints more correctly with what the internal node types are.
(node v20 was required as of 4c5cf21, but for some reason the action wasn't updated at the time)