feat: added optional short_app_name web config (#54) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OutdatedGuy mentioning you here as I can't add you as a reviewer |
OutdatedGuy
reviewed
May 9, 2024
OutdatedGuy
requested changes
May 9, 2024
OutdatedGuy
reviewed
May 13, 2024
OutdatedGuy
dismissed
their stale review
Checks are failing due to unused variable
Merged
|
awesome, thank you for merging and releasing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54.
This PR introduces a new feature that allows setting the
short_nameparameter in themanifest.jsonfile independently from thenameparameter for web configurations.Currently, the
app_nameparameter is used to set bothnameandshort_namein themanifest.jsonfile. With this change, we split theapp_nameparameter intoapp_nameandshort_app_nameto provide more flexibility.The
short_app_nameparameter is optional, and if not provided, it will default to the value ofapp_name.Note:
The error codes and messages used in the catch blocks are not actually used in the codebase. Please advise if these should be removed or if there are any plans to utilize them in the future.