RDOIBT-1832: Upgrade dependencies to remove vulnerability in node-fetch package #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-lmo
requested changes
Sep 14, 2023
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "dependencies": { | |||
| "classnames": "^2.2.5", | |||
| "memoize-one": "^5.0.0", | |||
| "prop-types": "^15.6.0", | |||
| "prop-types": "^15.6.2", | |||
There was a problem hiding this comment.
Besides, this change does not make sense because the prop-types version in package.json has a caret (it means that only the major number is locked). Hence, just doing a npm install, the prop-types version is upgraded to 15.8.1
There was a problem hiding this comment.
Right, running npm install is enough. I am just explicitly updating it here since 15.6.0 and 15.6.1 still have the vulnerability and it would seem a bit strange to me to keep it here, even with the caret
marianacapelo
changed the title
os-lmo
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading dependencies
Upgrade prop-types version to bump node-fetch to >= 2.6.7 (currently, 2.7.0) to remove vulnerability found by snyk.