ROU-11183: Include OnOrientationChange logic on MenuReady/MenuDestroy

[gnbm]

What was happening

• The app templates were released with some javascript nodes calling OutSystems UI framework APIs that the Developer doesn't know and that were only present in tablets and for older apps there's some manual work to be done.
• Since we now have MenuReady and MenuDestroy client actions, we should enclose this logic to avoid having JS nodes spread over the templates.

What was done

• Included the Orientation Change logic on Menu OnReady (this method now receives a callback) and OnDestroy
• Deprecated AddMenuOnOrientationChange and RemoveMenuOnOrientationChange
• Fixed some typos on the Menu.ts file
• Added the comments and @deprecate symbol to all methods within osui.ts file and added a new namespace to fallback the deprecated methods
• Fixed an issue raised by Snyk on the function _getUserAgent

Test Steps

• Test 1 - Old Apps - Tablet:

  • Go to a Tablet app
  • Switch between portrait and landscape
  • Check that the handler is triggered and the console.warn(...) on the developer tools console and the listener added

• Test 2 - Old Apps - Phone/Desktop:

  • Go to a Phone app
  • Switch between portrait and landscape
  • Check that no handler is triggered, no message is logged on the developer tools console and no listener is added
  • Repeated the same steps for a Desktop app

• Test 3 - New Apps - Tablet:

  • Go to a Tablet app
  • Switch between portrait and landscape
  • Check that the handler is triggered, no message is logged on the developer tools console and the listener is added

• Test 4 - New Apps - Phone/Desktop:

  • Go to a Phone app
  • Switch between portrait and landscape
  • Check that no handler is triggered, no message is logged on the developer tools console and no listener is added
  • Repeated the same steps for a Desktop app

Screenshots

Checklist

• tested locally
• documented the code
• clean all warnings and errors of eslint
• requires changes in OutSystems
• requires new sample page in OutSystems

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud