ROU-4388: Improve header's accessibility #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the headersFocusability property to "All" by default allowing the Row and column headers to be accessible via keyboard.
OS-giulianasilva
requested review from
gnbm,
joselrio,
BenOsodrac,
bmarcelino-fe,
rugoncalves and
JoaoFerreira-FrontEnd
as code owners
outsystemsbot
bot
added
the
cla:yes
BenOsodrac
approved these changes
Jun 26, 2023
gnbm
approved these changes
Jun 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
OS-giulianasilva
added a commit
that referenced
this pull request
Jul 24, 2023
* ROU-3748: Add client action to apply conditional format to the aggregate row (#331) * Add conditional format to ColumnAggregate * Fix SetRowAsSelected not returning error message * Fix lint warnings * Fix eslint warnings * Fix eslint warnings * Fix error code duplicated * Fix comments * Update OutSystems DataGrid version (#332) * Changed ClearFilter to allow triggering OnFiltersChange event Implement a way to trigger the OnFiltersChange event when using the ClearFilter * Update ToolTip.ts Add validation to check if we do have data available, for instance while using filters that make the Grid without results. * Adding new config to control the auto generate * Adding new ErrorMessage * Adding logic to not allow to generate columns if configs * Code readability improvement * Lint fix and adding comment * Changing language load mechanism * ROU-4329: Implement the ability to save/load layouts with frozen columns (#338) * Added ability to save/apply layouts with frozenCols - Added ability to save/apply layouts with frozenCols - Updated Lodash version (based on Snyk) - Updated TypeScript version (based on Snyk) * Update ColumnFreeze.ts --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> * Fixed issue in moveToPage Fixed issue in moveToPage() method that was always throwing an error * Adding changes to context menu * ROU-4320: Fix setRowAsSelected not working in a Grid with RowCheckboxes (#339) * Fix setRowAsSelected to work in a Grid with RowCheckboxes * Update setRowAsSelect method from Selection feature Add evaluation to check if the row indexes provided exist in the current Grid page * Update Selection.ts --------- Co-authored-by: Gonçalo M <goncalo.martins@outsystems.com> * Avoid raising event When the context menu event is opening. * Adding validation for widgetId * Remove unused url * Add a simple way to check for platform Id * Changes to the what is returned in the hit of the context menu * Fix and adding regional languages * typo fix * Adding isArray validation before wrap * ROU-3901: Update version and license after renewal - release 2023 V1 (#348) * Update Wijmo version * Fix issue in View._setGroups caused by WJM-22376 * Update wijmo.cloud.d.ts * Fix column picker issue after upgrade * Add comments * Fix eslint issues * Add new language "fr-CA" * Fix SetRowValidation API not working for Group Columns * Update ContextMenu.ts Fixed duplicated items inside Context Menu. * Improve headers accessibility (#350) Set the headersFocusability property to "All" by default allowing the Row and column headers to be accessible via keyboard. * Update ContextMenu.ts * Update ContextMenu.ts * Fix validateRow for GroupRows * New method to get OutSystems column by index * Check type of column on defining dirty mark * Fix on how to obtain the column by index * Update typedoc version * Fix Filter by Condition * Fix Filter by Value * Increment the version of target ES * Simplifying the code with ES2019 --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> Co-authored-by: rug <rmfgoncalves@gmail.com> Co-authored-by: Marcelino <brunoapmarcelino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for set Row and column headers to be accessible via keyboard.
What was happening
What was done
Test Steps
Checklist