Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMET-527 - iPad dismiss modal ImagePicker clicking outside issue fix #15

Merged
merged 1 commit into from
Feb 3, 2021
Merged

RMET-527 - iPad dismiss modal ImagePicker clicking outside issue fix #15

merged 1 commit into from
Feb 3, 2021

Conversation

andregrillo
Copy link

@andregrillo andregrillo commented Feb 3, 2021 •
edited
Loading

Description

Added a UIGestureRecognizer to detect clicks outside the UIImagePickerController

Context

Closes:
https://outsystemsrd.atlassian.net/browse/RMET-527

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
  • Documentation has been updated accordingly

vmfo22
vmfo22 approved these changes Feb 3, 2021
View reviewed changes
Copy link

@vmfo22 vmfo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this gesture have an impact in other use cases?

@andregrillo
Copy link
Author

Can this gesture have an impact in other use cases?

The UIGestureRecognizer is removed from the view as soon as the UIImagePicker is dismissed.
So, no, I don't think so.

@andregrillo andregrillo merged commit a3cffd9 into outsystems Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlsCorrea CarlsCorrea CarlsCorrea approved these changes

@vmfo22 vmfo22 vmfo22 approved these changes

@alexgerardojacinto alexgerardojacinto Awaiting requested review from alexgerardojacinto

@GFOutsystems GFOutsystems Awaiting requested review from GFOutsystems

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andregrillo @CarlsCorrea @vmfo22