RMET-3608 FB Dynamic Links - Update dependency to Firebase Dynamic Links Android SDK #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Dynamic Links Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608
Context: This build.gradle file wasn't even being used before because it wasn't referenced in the plugin.xml. Now, we just want to use it to declare the dependencies for the Firebase Android SDK for Dynamic Links, so we can remove this part. References: https://outsystemsrd.atlassian.net/browse/RMET-3608
This reverts commit 1fd056b.
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
alexgerardojacinto
removed request for
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
alexgerardojacinto
changed the title
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
IT-MikeS
approved these changes
Sep 13, 2024
ItsChaceD
approved these changes
Sep 13, 2024
alexgerardojacinto
added a commit
that referenced
this pull request
Sep 17, 2024
* chore: Raise Pod Version (#19) Raises Pod version to 8.15.0 References: https://outsystemsrd.atlassian.net/browse/RMET-3144 * RMET-3165 ::: Android ::: Update Gradle Dependencies (#20) * fix: Update Gradle Dependencies Update com.android.tools.build:gradle to 3.6.4 and com.google.gms:google-services to 4.3.14 References: https://outsystemsrd.atlassian.net/browse/RMET-3164 * chore: Add CHANGELOG entry References: https://outsystemsrd.atlassian.net/browse/RMET-3165 * RMET-3274 ::: iOS ::: Update 3rd Party that Adds Privacy Manifest (#22) * chore: Update iOS SDK version Update iOS' 3rd party SDK version to `10.23.0`. Enable the `use_frameworks` flag for CocoaPods. Fix import errors. References: https://outsystemsrd.atlassian.net/browse/RMET-3274 * chore: Update deprecated call Replace the `FIRDynamicLinks`'s `dynamicLinkFromUniversalLinkURL:` method with a new implementation using `dynamicLinkFromUniversalLinkURL:completion:`. This to fix a deprecation warning. References: https://outsystemsrd.atlassian.net/browse/RMET-3274 * chore: Add CHANGELOG entry References: https://outsystemsrd.atlassian.net/browse/RMET-3274 * chore: Set Release Version (#23) Prepare release of `5.0.0-OS11`. Clean `CHANGELOG`. References: https://outsystemsrd.atlassian.net/browse/RMET-3341 * RMET-3608 FB Dynamic Links - Update dependency to Firebase Dynamic Links Android SDK (#25) * feat: feat: use Firebase Android BOM library to set the version of FB Dynamic Links Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: reference build.gradle file in plugin.xml so it is included in the build References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore: remove unnecessary part of build.gradle file Context: This build.gradle file wasn't even being used before because it wasn't referenced in the plugin.xml. Now, we just want to use it to declare the dependencies for the Firebase Android SDK for Dynamic Links, so we can remove this part. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: include postBuildExtras step in Gradle References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * Revert "fix: include postBuildExtras step in Gradle" This reverts commit 1fd056b. * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore(release): raise to version 5.0.0-OS12 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 --------- Co-authored-by: Ricardo Silva <97543217+OS-ricardomoreirasilva@users.noreply.github.com> Co-authored-by: OS-ricardomoreirasilva <ricardo.moreira.silva@outsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
plugin.xmlto thebuild.gradlefile, following best practices, as this way we have more control on how dependencies are included in the app.build.gradlefile wasn't being used before, and so we removed thepostBuildExtrasstep from it, as it is not necessary for this plugin.Context
References: https://outsystemsrd.atlassian.net/browse/RMET-3608
Type of changes
Platforms affected
Tests
Tested on MABS 10 build, on Android 15 (Pixel 7) and Android 12 (Pixel 3XL)
MABS 10 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=3bbc9b27f095fcd3f41618defe8e1af9e5215cbf
Nativizer build with all supported plugins (including Firebase plugins + OneSignal): https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=41229af81be7c243397b3c20cb8fd5d5364dbd85
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>