Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMET-3804 - IAB Plugin - Remove unnecessary kotlin-kapt plugin #43

Merged
merged 8 commits into from
Nov 12, 2024
Merged

RMET-3804 - IAB Plugin - Remove unnecessary kotlin-kapt plugin #43

merged 8 commits into from
Nov 12, 2024

Conversation

alexgerardojacinto
Copy link
Contributor

Description

  • Removes the kotlin-kapt plugin from the Gradle file that was causing the a build issue with MABS 12 (capacitor-shell) and is not necessary.

Context

References: https://outsystemsrd.atlassian.net/browse/RMET-3804

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Tested on Android 15 Pixel 7 device.

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RMET-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto alexgerardojacinto requested a review from a team as a code owner November 8, 2024 18:02
@alexgerardojacinto alexgerardojacinto requested review from ItsChaceD, IT-MikeS, OS-ricardomoreirasilva and OS-martacarlos and removed request for a team November 8, 2024 18:02
@alexgerardojacinto alexgerardojacinto self-assigned this Nov 8, 2024
@alexgerardojacinto alexgerardojacinto changed the base branch from main to development November 8, 2024 18:02
@alexgerardojacinto alexgerardojacinto changed the title chore: remove unnecessary kotlin-kapt plugin RMET-3804 - IAB Plugin - Remove unnecessary kotlin-kapt plugin Nov 8, 2024
@alexgerardojacinto alexgerardojacinto marked this pull request as draft November 8, 2024 18:06
@alexgerardojacinto alexgerardojacinto marked this pull request as ready for review November 12, 2024 12:50
@alexgerardojacinto alexgerardojacinto merged commit 0541cc3 into development Nov 12, 2024
4 checks passed
@alexgerardojacinto alexgerardojacinto deleted the chore/rmet-3804/capacitor-shell-updates branch January 24, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OS-martacarlos OS-martacarlos OS-martacarlos approved these changes

@OS-ricardomoreirasilva OS-ricardomoreirasilva OS-ricardomoreirasilva approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD ItsChaceD is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

@IT-MikeS IT-MikeS Awaiting requested review from IT-MikeS IT-MikeS is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

Assignees

@alexgerardojacinto alexgerardojacinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgerardojacinto @OS-ricardomoreirasilva @OS-martacarlos