Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Connector Binary FIPS compliant #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cloud Connector Binary FIPS compliant #88

wants to merge 2 commits into from

Conversation

NewtonMan
Copy link

@NewtonMan NewtonMan commented Sep 17, 2024 •
edited
Loading

Important Note: To build this you should not be using goreleaser, you need to build using the Dockerfile, ex:
docker build . -t cloud-connector

@NewtonMan NewtonMan requested a review from a team as a code owner September 17, 2024 14:21
Matrikss
Matrikss reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Matrikss Matrikss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cannot be merged, it uses a private repo (edencore) to which our users don't have access to.
We probably should keep the findings and close the PR.

@bmartins-unit bmartins-unit added the do not merge This pull request should not be merged even if checks pass label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matrikss Matrikss Matrikss left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge This pull request should not be merged even if checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewtonMan @Matrikss @bmartins-unit