Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-2987 OSBarcodeLib-Android - Add zoom options #20

Merged
merged 22 commits into from
Mar 27, 2024

Conversation

alexgerardojacinto
Copy link
Collaborator

@alexgerardojacinto alexgerardojacinto commented Mar 26, 2024

Description

  • This PR adds the zoom buttons to the scanner UI, adding the following options:
    • Option for zooming out (zoom factor < 1), if the device supports it.
    • Option for 2x zoom, if device supports it.
    • Option for 1x zoom, if any other option is supported. If 1x is the only available option, no zoom buttons are shown in the UI.
  • It also changes the "Close" button according to the updates by the UI/UX team.

Context

References: https://outsystemsrd.atlassian.net/browse/RMET-2987

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

MABS 9 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=018b43f75b7d84ba7b086244f269a8407d37acb3

MABS 10 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=392f8dc4a2c3224bd9eacd9d3d61e130c61dc694

Tested in Pixel 7 with Android 14, and Pixel C tablet emulator with Android 14.

Screenshots (if appropriate)

Portrait

Screenshot_20240326-152757

Landscape

Screenshot_20240326-152806

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto alexgerardojacinto self-assigned this Mar 26, 2024
@alexgerardojacinto alexgerardojacinto changed the title Feat/rmet 2987/add zoom RMET-2987 OSBarcodeLib-Android - Add zoom options Mar 26, 2024
@alexgerardojacinto alexgerardojacinto requested review from a team, ItsChaceD, IT-MikeS, hectorjdgdev, OS-ricardomoreirasilva and OS-martacarlos and removed request for a team March 26, 2024 16:01
@alexgerardojacinto alexgerardojacinto marked this pull request as ready for review March 26, 2024 16:01
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexgerardojacinto alexgerardojacinto merged commit 8d77f6d into development Mar 27, 2024
7 checks passed
@alexgerardojacinto alexgerardojacinto deleted the feat/RMET-2987/add-zoom branch March 27, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants