Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_hourly_temperature floors time to day #1939

Merged
merged 1 commit into from
Oct 3, 2024
Merged

make_hourly_temperature floors time to day #1939

merged 1 commit into from
Oct 3, 2024

Conversation

saschahofmann
Copy link
Contributor

@saschahofmann saschahofmann commented Oct 3, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • make_hourly_temperature floors time to day

aulemahal
aulemahal approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right.

@Zeitsperre Zeitsperre added the approved Approved for additional tests label Oct 3, 2024
@Zeitsperre Zeitsperre merged commit a66b06c into Ouranosinc:main Oct 3, 2024
29 checks passed
@Zeitsperre
Copy link
Collaborator

Thanks so much @saschahofmann!

@saschahofmann saschahofmann deleted the fix-#1938 branch October 3, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory issue and additional day from make_hourly_temperature
3 participants
@saschahofmann @Zeitsperre @aulemahal