Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFS requests using POST #301

Closed
wants to merge 12 commits into from
Closed

WFS requests using POST #301

wants to merge 12 commits into from

Conversation

Zeitsperre
Copy link
Contributor

Overview

This PR fixes #297

Changes:

  • Added POST support for one of the WFS-enabled WPS requests (hydrobasins-select)
  • Added method flags to specify the methods of requests ({"GET", "POST"}) that can be requested.

Related Issue / Discussion

geopython/OWSLib#706

Additional Information

Links to other issues or sources.

@Zeitsperre Zeitsperre marked this pull request as ready for review November 24, 2020 22:18
@Zeitsperre Zeitsperre self-assigned this Nov 24, 2020
@Zeitsperre Zeitsperre added the enhancement New feature or request label Nov 24, 2020
@Zeitsperre
Copy link
Contributor Author

@huard this seems to be working using the fixes and workarounds developed by @f-PLT. POST is now implemented for the hydrobasins-select WPS process.

huard
huard reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this function ever had an issue with GET requests exceeding a limit. I realized looking into this the culprit was in flyingpigeon. So not clear this PR is necessary.

raven/utilities/gis.py Outdated Show resolved Hide resolved
@Zeitsperre
Copy link
Contributor Author

I leave the decision of merging to you.

@huard huard closed this Nov 27, 2020
@Zeitsperre Zeitsperre deleted the fix_297 branch November 27, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard left review comments

Assignees

@Zeitsperre Zeitsperre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test OWSLib PR allowing POST for WFS getfeature requests
2 participants
@Zeitsperre @huard