Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/auth0 vue3 #30

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Feature/auth0 vue3 #30

merged 4 commits into from
Jun 12, 2020

Conversation

kaniak274
Copy link
Contributor

@kaniak274 kaniak274 commented Jun 10, 2020 •
edited
Loading

This pr does few things:

  1. Adds support for auth0 plugin to vue3
  2. Adds typescript support to the project
  3. I've change Home.vue to completely use new vue API.

Remarks:

  1. Don't mind errors when client is starting. These errors are not ours but from vue app. (fix(ExtractComputedReturns): use explicit Record type vuejs/core#1195)
  2. It doesn't mean we have to use typescript from now on. I just wanted to make the plugin a little better.
  3. This is not ideal solution but for know it should be fine.

In this pr I introduce some new features of vue3 if you have any questions or anything is not clear just ask me.

@kaniak274 kaniak274 requested a review from KamilSupera June 10, 2020 19:47
@KamilSupera KamilSupera merged commit c595ca8 into feature/vue3-docker Jun 12, 2020
@KamilSupera KamilSupera deleted the feature/auth0-vue3 branch June 12, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilSupera KamilSupera KamilSupera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaniak274 @KamilSupera