Prepare for IPv6 by changing datatype #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeMan
commented
Dec 22, 2021
•
HeMan
commented
- Make ESPAsyncTCP work with IPv6 by changing internal datatype from ip_addr_t to IPAddress. Still works with IPv4 only configuration.
HeMan
changed the title
- Was ip_addr_t, changed it to IPAddress which has support for IPv6 by using operator overloading and such.
|
@OttoWinter I got an IPv6-patch accepted in ESPHome and like to continue with the ESP8266-part if possible. Could you please review this patch? |
|
Bump! Could you please consider this PR? |
|
@OttoWinter Can I do anything to get this PR merged? |
|
@OttoWinter ping? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.