Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix discog downloads (#150) #152

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Conversation

Nebula-Mechanica
Copy link
Contributor

@Nebula-Mechanica Nebula-Mechanica commented Sep 10, 2020

Hello!

Trying to fix broken discography download. Since band_url is not available anymore, we'll try to get artist part from the url of the link itself.

@ghost
Copy link

ghost commented Sep 29, 2020

I've used this solution and it seemed to work. Was able to download an entire discography fine. Though it now seems inconsistent as well? Not sure what's going on but I'm gonna look in the code a little more.

Update: Just me being a noob at visual studio. Found that its working for the exe file now.

@Otiel Otiel changed the base branch from master to develop October 30, 2020 15:15
@Otiel Otiel merged commit 42971c1 into Otiel:develop Oct 30, 2020
@Otiel
Copy link
Owner

Otiel commented Oct 30, 2020

Hi @Nebula-Mechanica!

Thanks for the fix, and sorry for the delay to merge this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants