Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create m3u playlist #82

Closed
l0oo opened this issue Apr 18, 2019 · 11 comments
Closed

Create m3u playlist #82

l0oo opened this issue Apr 18, 2019 · 11 comments
Assignees
Labels
feature-request New feature or request

Comments

@l0oo
Copy link
Contributor

l0oo commented Apr 18, 2019

Just an idea...
IMHO would be nice to have such feature in BandcampDownloader.

@Otiel Otiel changed the title What about to create m3u playlist? Feature request Create m3u playlist Apr 18, 2019
@Otiel Otiel added the feature-request New feature or request label Apr 18, 2019
@Otiel
Copy link
Owner

Otiel commented Apr 18, 2019

Thanks for the suggestion.

A few questions to identify how we should implement this:

  1. Should we create one m3u file per album, regardless of the download path (even if all albums are stored in the same folder)?
  2. Should we create a m3u file for albums containing only one track?
  3. Should we create a m3u file for track pages (thus containing only one track) as well?
  4. Where should we store the m3u file in case the download path contains placeholders ({album} for instance)? In the end folder?

@l0oo
Copy link
Contributor Author

l0oo commented Apr 18, 2019

Hello Otiel!

Thank you for answer!
IMO the best would be create m3u file inside folder where album's mp3s are stored - so one per album. Some use {artist} - {album} ({year}), some {artist}/{album} - so it is universal imho. If all albums (you mean mp3 files?) are in same folder too - this way someone can play album he wants, without picking songs manually.

  1. One track album
    I think yes, as some albums are one track only, some are not complete (some have just two songs published of ten etc, anyway - numbers of tracks will be preserved in filenames thus m3u).

  2. Track pages
    Well - I guess yes. As finally those file(s) land in folder and have 'artist - title'.

  3. {album}
    Yup - IMHO in the end folder. As I wrote above.

BTW: There is nice small app where some problems with BOM are adressed.
http://www.dcmembers.com/skwire/download/splaylistmaker/
IMHO OK would be .m3u, UTF-8 (with BOM) - as some titles may have exotic diacritics etc...

All this could be of course optional etc. So someone could make it according to own taste / needs / habits.

Rgrds!

@Otiel
Copy link
Owner

Otiel commented Apr 19, 2019

you mean mp3 files?

Yes that's what I meant.

Ok, I see we are on the same page, good! 👍 I'll start working on this when I find the time then.

Thanks for the link, I'll make sure "special" characters are supported as best as possible.

@Otiel Otiel self-assigned this Apr 23, 2019
@Otiel Otiel added this to the Next version milestone Apr 24, 2019
@Otiel Otiel closed this as completed in fd4d270 Apr 24, 2019
@Otiel
Copy link
Owner

Otiel commented Apr 24, 2019

Done in v0.2.8.0. Let me know if that's good for you.

@Otiel Otiel removed this from the Next version milestone Apr 24, 2019
@l0oo
Copy link
Contributor Author

l0oo commented Apr 25, 2019 via email

@Otiel
Copy link
Owner

Otiel commented Apr 25, 2019

As my naming scheme for songs is: {tracknum} {artist} - {title}.mp3
Created m3u must reproduce this scheme. :/ If not - files aren't played.

You are right. That's a bug. I'll fix this in the next version.

I have another small idea...

Let's continue the discussion for this in #85.

@Otiel Otiel added this to the Next version milestone Apr 25, 2019
@Otiel Otiel closed this as completed in fe740ae Apr 25, 2019
@Otiel
Copy link
Owner

Otiel commented Apr 25, 2019

You are right. That's a bug. I'll fix this in the next version.

It should be fixed in v0.2.8.2

@l0oo
Copy link
Contributor Author

l0oo commented Apr 29, 2019 via email

@Otiel
Copy link
Owner

Otiel commented Apr 29, 2019

Thanks for the example URL. I'll check it out.

@Otiel Otiel reopened this Apr 29, 2019
@Otiel Otiel closed this as completed in da9a43f May 4, 2019
@Otiel
Copy link
Owner

Otiel commented May 4, 2019

New try: v0.2.9.0

It should fix the issue with foreign characters. Please let me know if all is ok for you now.

@l0oo
Copy link
Contributor Author

l0oo commented May 6, 2019 via email

@Otiel Otiel removed this from the Next version milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants