This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[sonarqube] Add optional serviceaccount creation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjkernick
suggested changes
Mar 26, 2020
| {{- end }} | ||
| {{- if .Values.serviceAccount.annotations }} | ||
| annotations: | ||
| {{ toYaml .Values.serviceAccount.annotations | nindent 4 }} |
There was a problem hiding this comment.
Please fix the typo on indent.
rjkernick
approved these changes
Mar 26, 2020
|
Thank you for the quick review! When can I expect it to be merged? We are currently using the chart from my fork and would be happy to use the official chart instead. |
rjkernick
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional functionality to create a new or use an existing k8s serviceAccount.
Probably useful when using RBAC.