Add support for OpenAI-compatible API provider and optional base URL #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaumikmaan
requested changes
Apr 15, 2025
| @@ -20,6 +21,7 @@ export class ConfigHelper extends EventEmitter { | |||
| private defaultConfig: Config = { | |||
| apiKey: "", | |||
| apiProvider: "gemini", // Default to Gemini | |||
| baseUrl: "", // Optional custom API URL | |||
There was a problem hiding this comment.
Not sure about this change
seems like it beats the point of the default model
| updates.extractionModel = "Claude#claude-3-7-sonnet-20250219"; | ||
| updates.solutionModel = "Claude#claude-3-7-sonnet-20250219"; | ||
| updates.debuggingModel = "Claude#claude-3-7-sonnet-20250219"; | ||
| } else if (updates.apiProvider === "openai-compatible") { |
There was a problem hiding this comment.
If updates.apiProvider === "openai-compatible"
why are the models for it claude-3-7-sonnet-20250219
Comment on lines
+510
to
+514
| const jsonRegex = /```json\n([\s\S]*?)\n```/; | ||
| const match = responseText.match(jsonRegex); | ||
| if (match && match[1]) { | ||
| problemInfo = JSON.parse(match[1]); | ||
| } |
There was a problem hiding this comment.
What was the need of the change here?
Also I think
if (match && match[1]) {
problemInfo = JSON.parse(match[1]);
}there's a better way to do this matching
Comment on lines
+257
to
+261
| } else if (provider === "openai-compatible") { | ||
| // For OpenAI-compatible APIs, we'll keep the current models or set defaults | ||
| if (!extractionModel) setExtractionModel("gpt-3.5-turbo"); | ||
| if (!solutionModel) setSolutionModel("gpt-3.5-turbo"); | ||
| if (!debuggingModel) setDebuggingModel("gpt-3.5-turbo"); |
There was a problem hiding this comment.
Here we are creating a new model but in ProcessingHelper.ts here
you are using the same client? So why not bifurcate that too
| @@ -325,9 +334,9 @@ export function SettingsDialog({ open: externalOpen, onOpenChange }: SettingsDia | |||
| {/* API Provider Selection */} | |||
| <div className="space-y-2"> | |||
| <label className="text-sm font-medium text-white">API Provider</label> | |||
| <div className="flex gap-2"> | |||
| <div className="grid grid-cols-2 gap-2 mb-2"> | |||
Comment on lines
+398
to
+417
| <div | ||
| className={`p-2 rounded-lg cursor-pointer transition-colors ${ | ||
| apiProvider === "openai-compatible" | ||
| ? "bg-white/10 border border-white/20" | ||
| : "bg-black/30 border border-white/5 hover:bg-white/5" | ||
| }`} | ||
| onClick={() => handleProviderChange("openai-compatible")} | ||
| > | ||
| <div className="flex items-center gap-2"> | ||
| <div | ||
| className={`w-3 h-3 rounded-full ${ | ||
| apiProvider === "openai-compatible" ? "bg-white" : "bg-white/20" | ||
| }`} | ||
| /> | ||
| <div className="flex flex-col"> | ||
| <p className="font-medium text-white text-sm">OpenAI Compatible</p> | ||
| <p className="text-xs text-white/60">Open Router, etc.</p> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Again here, I would rather have you support a new model with everything made specifically for that model rather than creating new at some places and making changes in others
| <div className="mt-2 p-2 rounded-md bg-white/5 border border-white/10"> | ||
| <p className="text-xs text-white/80 mb-1">Don't have an API key?</p> | ||
| {apiProvider === "openai" ? ( | ||
| {apiProvider === "openai" && ( |
Comment on lines
+607
to
+618
| {apiProvider === "openai-compatible" && ( | ||
| <Input | ||
| id="extractionModelCustom" | ||
| type="text" | ||
| value={currentValue} | ||
| onChange={(e) => setValue(e.target.value)} | ||
| placeholder="gpt-3.5-turbo" | ||
| className="bg-black/50 border-white/10 text-white" | ||
| /> | ||
| )} | ||
|
|
||
| {apiProvider !== "openai-compatible" && models.map((m) => { |
There was a problem hiding this comment.
Why separate handling?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to use openAI compatible providers.
fix error on parse JSON responses.