Skip to content

Adding github workflows for code cleanup and CI #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 10, 2025

Conversation

bhaumikmaan
Copy link
Collaborator

@bhaumikmaan bhaumikmaan commented Apr 9, 2025

FEATURE

Adding workflows to the repository so it runs automatic checks for PRs and contributions.

  1. Added codeql.yml for code clean up
  2. Added ci.yml for build, install and dependency checks

All these will run on their own when a commit/PR is directed towards main

NOTE: This may take a lot of commits because of the discrepancy in local and github configurations and dependencies

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

bhaumikmaan and others added 2 commits April 9, 2025 11:39
The CI may fail as of now because there is a technical debt
@bhaumikmaan bhaumikmaan changed the title Create codeql.yml Adding github workflows for code cleanup and CI Apr 9, 2025
@us1415 us1415 self-requested a review April 9, 2025 17:06
@us1415 us1415 marked this pull request as ready for review April 9, 2025 17:06
Copy link
Collaborator

@us1415 us1415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent used github actions yet but have used GitLab CI for the past 5 years. Looks about the same. Thank you @bhaumikmaan !

@bhaumikmaan bhaumikmaan marked this pull request as draft April 9, 2025 17:11
@bhaumikmaan
Copy link
Collaborator Author

bhaumikmaan commented Apr 9, 2025

Thanks for the approval.
Will create relevant issues tomorrow morning hence drafting for now so no one merges it unexpectedly

Copy link
Owner

@Ornithopter-pilot Ornithopter-pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work fellow human

@bhaumikmaan bhaumikmaan linked an issue Apr 10, 2025 that may be closed by this pull request
@bhaumikmaan bhaumikmaan marked this pull request as ready for review April 10, 2025 04:08
@bhaumikmaan bhaumikmaan merged commit 6f8695f into main Apr 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About workflows and pipelines
3 participants