fixed obacity problems on linux #42
Conversation
| @@ -0,0 +1 @@ | |||
| - @azure Rule - Use Azure Best Practices: When generating code for Azure, running terminal commands for Azure, or performing operations related to Azure, invoke your `get_azure_best_practices` tool if available.c | |||
There was a problem hiding this comment.
Remove, unnecessary change
There was a problem hiding this comment.
Remove, unnecessary change.
Added due to permission changes in linux
| // Linux-specific fix: Hide the window completely rather than just setting opacity | ||
| if (process.platform === 'linux') { | ||
| state.mainWindow.hide(); | ||
| } | ||
|
|
There was a problem hiding this comment.
If this is only for linux, where is the state.mainWindow.hide() for the other OS?
There was a problem hiding this comment.
I think the idea is that on Linux we straight up hide the window, but Windows and Mac we just set opacity to 0, so no need to hide the window on non-Linux platforms.
| if (process.platform === 'linux') { | ||
| state.mainWindow.show(); | ||
| state.mainWindow.focus(); | ||
| // Set opacity after showing to ensure the window is visible | ||
| state.mainWindow.setOpacity(configHelper.getOpacity()); | ||
| } else { | ||
| // Mac/Windows behavior | ||
| state.mainWindow.setOpacity(0); // Set opacity to 0 before showing | ||
| state.mainWindow.showInactive(); // Use showInactive instead of show+focus | ||
| state.mainWindow.setOpacity(1); // Then set opacity to 1 after showing | ||
| } | ||
|
|
There was a problem hiding this comment.
Are you sure this is working for other OS?
Since you are tweaking the opacity not the window itself
|
|
||
| // Linux-specific handling for opacity changes | ||
| if (process.platform === 'linux') { |
There was a problem hiding this comment.
Again, streamlining the implementation for Linux OS still needs verification that it is not breaking other OS
Since using Ctrl + B on Linux distributions like Kubuntu didn't work as expected, I modified the configuration to completely hide the window when pressing Ctrl + B.