Storybook #95
Merged
Storybook #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xasopheno
force-pushed
the
dm/storybook
branch
from
18ad28e to
9975feb
Compare
xasopheno
commented
Nov 10, 2020
| "concurrently": "^5.3.0", | ||
| "eslint-plugin-graphql": "^4.0.0", | ||
| "storybook-css-modules-preset": "^1.0.2", |
There was a problem hiding this comment.
This should be dropped if we opt for another css framework.
hallettj
approved these changes
Nov 11, 2020
Comment on lines
+35
to
+36
| "babel-loader": "^8.2.0", | ||
| "babel-preset-react-app": "^10.0.0", |
There was a problem hiding this comment.
I'm a bit bothered by adding these babel dependencies if we don't directly reference them. Are they necessary? This applies to @babel/core too.
There was a problem hiding this comment.
Seems that babel is required for storybook.
storybookjs/storybook#7156
Co-authored-by: Jesse Hallett <jesse.hallett@originate.com>
Co-authored-by: Jesse Hallett <jesse.hallett@originate.com>
xasopheno
force-pushed
the
dm/storybook
branch
from
ffbcfe3 to
02449e9
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Storybook with support for CSS modules. Definition following in my editor does not go to the css definition, but instead the module declarations. Maybe this is just a kink in my setup.