This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Proxy Account and Meta Transactions #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* copy identity package as part of notifications * typo * typo 2
* Fix notifications container * Rename logger for notifications
* Fix SafeAreaView problem * Improve network detection
* Fix SafeAreaView on marketplace screen * Bump bundle
* Add clodubuild file * Add signing files * Android build work * Update google-services.json * Downgrade react-native-push-notifications * Upgrade gradle * Add encrypted keystore properties * Gitignore keystore.properties * Remove signing dir * Fix paths * Updates for automated builds * Update keystore properties * Remove ports that no longer need forwarding * Revert "Remove ports that no longer need forwarding" This reverts commit 0430c9b. * Fix issue with notifications modal interferign with signing * Update image
* More restrictive searching and more relevant results * Fix test
franckc
approved these changes
May 10, 2019
shahthepro
reviewed
May 10, 2019
There was a problem hiding this comment.
@nick Everything looks good to me. But there is a potential security bug in the IdentityProxy.s file. We may have to sort it out.
|
@franckc @shahthepro ready for final review now... it's all wired off so we should be OK to merge to master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Since we're now supporting both direct wallet AND proxy identity interactions with our contracts, I have introduced the concept of an Account 'owner' in GraphQL. This will return the controlling wallet in the case of a Proxy account, or the same wallet address if the account is just a wallet.
For example, if the seller is a wallet
0xabthen bothlisting.seller.idandlisting.seller.owner.idwill return0xabcIf the seller is an account proxy
0xdefwith owner0xabc, thenlisting.seller.idwill return0xdefandlisting.seller.owner.idwill return0xabcThe actual use of Proxy account is disabled by default. Use env var
ENABLE_PROXY_ACCOUNTS=1to enable them.