Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Fixes an event arg for getEvents #2125

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fixes an event arg for getEvents #2125

merged 1 commit into from
Apr 26, 2019

Conversation

mikeshultz
Copy link
Contributor

Description:

This was missed in my original PR #1975 Event args given to EventCache.getEvents should be strings since that's what's originally returned by web3.js.

Checklist:

@mikeshultz mikeshultz added bug Something isn't working as intended graphql labels Apr 26, 2019
@mikeshultz mikeshultz requested review from nick and franckc April 26, 2019 03:24
@mikeshultz mikeshultz self-assigned this Apr 26, 2019
franckc
franckc approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@franckc franckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What's the impact of this issue ? Looks like it would cause all offers to fail loading ?
Shall we deploy to prod asap ?

@franckc franckc merged commit 428a59d into master Apr 26, 2019
@franckc franckc deleted the mikeshultz/txhistory-fix branch April 26, 2019 03:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@franckc franckc franckc approved these changes

@nick nick Awaiting requested review from nick

Assignees

@mikeshultz mikeshultz

Labels
bug Something isn't working as intended graphql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeshultz @franckc