Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Handle null transaction hash returned by web3 #3574

Open
mikeshultz opened this issue Sep 30, 2019 · 1 comment
Open

Handle null transaction hash returned by web3 #3574

mikeshultz opened this issue Sep 30, 2019 · 1 comment
Labels
bug Something isn't working as intended graphql P2 Small number of users are affected, major cosmetic issue

Comments

@mikeshultz
Copy link
Contributor

https://sentry.io/organizations/origin-protocol/issues/1247501267/events/848d565c124c49b7966b976ac9dcf85a/?project=1402589

I didn't think this was supposed to be a thing, but it appears some versions of web3 will return a null value for transaction has on the .once('transactionHash') event handler.

Ref #3275
@mikeshultz mikeshultz added bug Something isn't working as intended graphql P2 Small number of users are affected, major cosmetic issue labels Sep 30, 2019
@mikeshultz mikeshultz mentioned this issue Sep 30, 2019
Closed
mikeshultz added a commit that referenced this issue Oct 1, 2019
@mikeshultz
small logic adjustments to how weird transaction hash values are hand…
3742b08 
…led. Issues #3573 #3574 #3275
@mikeshultz mikeshultz mentioned this issue Oct 1, 2019
Merged
4 tasks
mikeshultz added a commit that referenced this issue Oct 1, 2019
@mikeshultz
Transaction hash handling (#3589)
a712c37 
* small logic adjustments to how weird transaction hash values are handled.  Issues #3573 #3574 #3275

* prevent refetch when hash is pending, and integrate @nick's feedback
@mikeshultz
Copy link
Contributor Author

Added some instrumentation with #3589. This issue will get a unique error now and also dump the transaction to console for diagnostics. According to other reports on the interwebs, this can be caused by a gas prices being too low for the node to accept, and possibly other transaction errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working as intended graphql P2 Small number of users are affected, major cosmetic issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeshultz