Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfresco Content Services 23.1 compatibility #215

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

AFaust
Copy link
Contributor

@AFaust AFaust commented Dec 2, 2023

CHECKLIST

We will not consider a PR until the following items are checked off--thank you!

  • There aren't existing pull requests attempting to address the issue mentioned here
  • Submission developed in a feature branch--not master

CONVINCING DESCRIPTION

This PR adds compatibility with the ACS 23.1 release. This is done by splitting the log download servlets in Share into distinct Java EE + Jakarta EE-based servlets. The servlets themself remain relevant due to the issues described in the issue #99

RELATED INFORMATION

Fixes #214

Adding @aborroy in addition to reviewers as he offered to help and I reckon he might be able to help in doing some testing.

Copy link
Contributor

@aborroy aborroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR successfully with ACS 23.1 and ACS 7.4.
The wrapper approach seems good to me.

@p4535992
Copy link

p4535992 commented Feb 19, 2024

This PR Seem to work

@AFaust
Copy link
Contributor Author

AFaust commented Feb 19, 2024

After granting myself (the primary maintainer and original author) the project privilege to skip PR requirements, I will be merging it considering the feedback from non-maintainers and the time the PR was already waiting for formal review by other maintainers.

@AFaust AFaust merged commit 2099800 into OrderOfTheBee:master Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with ACS 23.1
6 participants