Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal all controllers #16576

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Seal all controllers #16576

merged 5 commits into from
Aug 16, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@MikeAlhayek MikeAlhayek requested a review from Piedone August 16, 2024 22:06
Piedone
Piedone reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Are there any controllers that you decided to deliberately not seal? If yes, why?

Piedone
Piedone requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered that this can be easily checked with a public class .* : Controller search, and the answer is "no". However, the samples in the docs contain unsealed controllers, which I guess should all be changed too.

@MikeAlhayek
Copy link
Member Author

no. all controllers should be sealed. Did I miss any controllers?

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Aug 16, 2024 •
edited
Loading

@Piedone I just updated the controller docs.
I did not do a text search. I right clicked on Controller class and clicked on Find All References. The did the something with ControllerBase

@MikeAlhayek MikeAlhayek requested a review from Piedone August 16, 2024 23:07
@MikeAlhayek MikeAlhayek enabled auto-merge (squash) August 16, 2024 23:08
@MikeAlhayek MikeAlhayek merged commit f9fcfa0 into main Aug 16, 2024
12 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/seal-controllers branch August 16, 2024 23:11
This was referenced Sep 1, 2024
Open
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeAlhayek @Piedone