Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set as startup task button for non-event activities #16351

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Remove set as startup task button for non-event activities #16351

merged 6 commits into from
Jul 4, 2024

Conversation

mdameer
Copy link
Contributor

@mdameer mdameer commented Jun 20, 2024

Fix #16345

Remove set as startup task button for non-event activities
Rename "Startup task" tooltip to "Startup event"

@mdameer mdameer changed the title 16345 fix task activity startup Remove set as startup task button for non-event activities Jun 20, 2024
@mdameer @hishamco
Add empty line
8539a66 
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
@mdameer mdameer requested a review from hishamco June 20, 2024 06:04
@hishamco
Copy link
Member

I already approved the PR :)

@Piedone can we merge this

Piedone
Piedone approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. But let's wait for the triage meeting later today to validate the issue in the first place :). Then I'll immediately merge if OK.

@Piedone
Copy link
Member

Piedone commented Jun 23, 2024

We didn't have a meeting this week, so let's see again next week.

BTW you don't need to continuously merge from main (unless there's a new merge conflict).

@hishamco
Copy link
Member

We didn't have a meeting this week, so let's see again next week.

Is Seb ok?

This was referenced Jul 1, 2024
Open
Closed
@Piedone Piedone merged commit 5207b37 into OrchardCMS:main Jul 4, 2024
5 checks passed
@Piedone
Copy link
Member

Piedone commented Jul 4, 2024

Too much waiting :).

@mdameer mdameer deleted the 16345-fix-task-activity-startup branch July 4, 2024 22:09
@MikeAlhayek MikeAlhayek mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

@hishamco hishamco hishamco approved these changes

Assignees
No one assigned
Labels
don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task-type Workflows Activities an also be set as startup task
3 participants
@mdameer @hishamco @Piedone