Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless placeholder file #12954

Merged

Conversation

TFleury
Copy link
Contributor

@TFleury TFleury commented Dec 15, 2022

No description provided.

@Skrypt
Copy link
Contributor

Skrypt commented Dec 15, 2022

Hmm good one. I think at some point it was necessary to keep it, can't remember why. @jtkech

@TFleury
Copy link
Contributor Author

TFleury commented Dec 15, 2022

I think it was necessary before having some code in the project. But since there is a Startup and controller in project, placeholder is useless.

@jtkech
Copy link
Member

jtkech commented Dec 15, 2022

As I remember it is a concern about creating the directory when publishing the wwwroot of the web application, but normally not a problem with the embedded files of a module / theme.

But at least should be tried ;)

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Copy link
Member

@TFleury

As I remember it is a concern about creating the directory when publishing the wwwroot of the web application, but normally not a problem with the embedded files of a module / theme.

Did you try removing that file and then publishing to ensure the embedded files of modules and theme don't break?

@TFleury TFleury force-pushed the pr/removeTheThemePlaceholder branch from 3af150c to 887b067 Compare February 6, 2024 11:10
@TFleury
Copy link
Contributor Author

TFleury commented Feb 6, 2024

I tried removing the file and the published directory structure is strictly the same.
I tested the output and didn't encountered any problem creating a new site.

@sebastienros sebastienros merged commit 2fa80a1 into OrchardCMS:main Feb 8, 2024
4 checks passed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants