Add docs for ThemeSelectorResult #11147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the wrong with https://nodejs.org/dist/v15.14.0?!! |
Skrypt
reviewed
Feb 8, 2022
src/OrchardCore/OrchardCore.DisplayManagement/Theming/ThemeSelectorResult.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement/Theming/ThemeSelectorResult.cs
Outdated
Show resolved
Hide resolved
…ectorResult.cs Co-authored-by: Dean Marcussen <dean.marcussen@gmail.com>
Piedone
approved these changes
Mar 13, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Co-authored-by: Dean Marcussen <dean.marcussen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue here is to avoid the expectation of
ThemeNamemany of the dev may expect the theme name is used inThemeSelectorResultwhile the identifier is used instead. @agriffard if we need add remark on the docs please let me know where should we add it