-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload Theme Packages #8346
Comments
Something similar was available for Orchard 1 both for modules and themes. I've never really seen the appeal though: installing a plugin into your deployed app on the fly is very risky. Then you also have to somehow have a downstream option to keep these plugins by e.g. somehow exporting them, so you can move the site's configuration to another place like running it locally. If Orchard would be an app that you just use, even if you host it yourself, like TeamCity, I'd agree this could be useful. However, Orchard is rather used as an application platform where you also develop your own app with it. |
This could potentially work if we would/could be using Admin Liquid Templates for everything. Then the assets could also be editable through the media gallery or something like it. Let's say we start from a "blank" frontend theme. All we would need is create a recipe that creates Liquid templates stored in the DB. And bundle some assets in a .rar file? That's how for example Shopify works ... So, in this case we don't talk about changing the server side theme but to allow to edit the current one from the admin UI. |
BTW Lombiq Hosting - Media Theme for Orchard Core is something like what you envision. |
For all intents and purposes, the previously linked Media Theme covers this. I don't think we'll ever have a feature to upload actual theme packages with C# code files, since that would entail modifying and recompiling the application while it's running, which while technically possible, would be risky and also unnecessary due to what I've written under #8346 (comment). What's that's not covered for you by Media Theme, the built-in way of editing templates (and uploading CSS/JS files) from the admin, or by the GrapeJS HTML Editor? Related: #3279 |
Regardless of security, if you want to develop this feature, you can refer to this code. |
It seems that this issue didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please reply. |
Closing this issue because it didn't receive further feedback from the author for very long. If you think this is still relevant, feel free to reopen it with the requested details. |
I think Orchard Core really needs the ability to upload a theme package if it is to compete with other CMS’s on the market.
I am just going to take a stab at a possible implementation.
You guys would know best how to implement it. This is just to communicate the idea.
considered.
The text was updated successfully, but these errors were encountered: