Silently omit exception from Redis #16483

infofromca · 2024-07-24T14:14:29Z

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is.
Currently if the Redis is enabled and Redis server is not available, the whole site will fail in the beginning.

Describe the solution you'd like

A clear and concise description of what you want to happen.

it should not influence the whole site.

==========
An unhandled exception occurred while processing the request.
RedisConnectionException: It was not possible to connect to the redis server(s). Error connecting right now. To allow this multiplexer to continue retrying until it's able to connect, use abortConnect=false in your connection string or AbortOnConnectFail=false; in your code.
StackExchange.Redis.ConnectionMultiplexer.ConnectImplAsync(ConfigurationOptions configuration, TextWriter writer, Nullable<ServerType> serverType) in ConnectionMultiplexer.cs, line 620

Stack Query Cookies Headers Routing
RedisConnectionException: It was not possible to connect to the redis server(s). Error connecting right now. To allow this multiplexer to continue retrying until it's able to connect, use abortConnect=false in your connection string or AbortOnConnectFail=false; in your code.
StackExchange.Redis.ConnectionMultiplexer.ConnectImplAsync(ConfigurationOptions configuration, TextWriter writer, Nullable<ServerType> serverType) in ConnectionMultiplexer.cs
OrchardCore.Redis.Services.RedisDatabaseFactory+<>c__DisplayClass6_0+<<CreateAsync>b__0>d.MoveNext()
OrchardCore.Redis.Services.RedisService.ConnectAsync()
OrchardCore.Environment.Shell.Scope.ShellScope+<>c+<<ActivateShellInternalAsync>b__43_0>d.MoveNext()
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.ActivateShellInternalAsync()
OrchardCore.Environment.Shell.Scope.ShellScope.ActivateShellInternalAsync()
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Modules.ModularTenantContainerMiddleware.Invoke(HttpContext httpContext)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

Show raw exception details
StackExchange.Redis.RedisConnectionException: It was not possible to connect to the redis server(s). Error connecting right now. To allow this multiplexer to continue retrying until it's able to connect, use abortConnect=false in your connection string or AbortOnConnectFail=false; in your code.
   at StackExchange.Redis.ConnectionMultiplexer.ConnectImplAsync(ConfigurationOptions configuration, TextWriter writer, Nullable`1 serverType) in /_/src/StackExchange.Redis/ConnectionMultiplexer.cs:line 620
   at OrchardCore.Redis.Services.RedisDatabaseFactory.<>c__DisplayClass6_0.<<CreateAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Redis.Services.RedisService.ConnectAsync()
   at OrchardCore.Environment.Shell.Scope.ShellScope.<>c.<<ActivateShellInternalAsync>b__43_0>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.ActivateShellInternalAsync()
   at OrchardCore.Environment.Shell.Scope.ShellScope.ActivateShellInternalAsync()
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func`2 execute, Boolean activateShell)
   at OrchardCore.Modules.ModularTenantContainerMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

The text was updated successfully, but these errors were encountered:

hishamco · 2024-07-24T14:37:14Z

Please steps to reproduce

infofromca · 2024-07-24T15:08:48Z

1--enable Redis feature
2--no redis server
3--got result

hishamco · 2024-07-24T15:21:32Z

2--no redis server

Redis Server should be running

MikeAlhayek · 2024-07-24T16:21:21Z

It sounds like your Redis server is not reachable from your localhost

RedisConnectionException: It was not possible to connect to the redis server(s). Error connecting right now. To allow this multiplexer to continue retrying until it's able to connect, use abortConnect=false in your connection string or AbortOnConnectFail=false; in your code.

infofromca · 2024-07-24T19:45:57Z

the home page of the site did not call IRedisService or any other Redis stuff.
why even for home page , the site was down.
IMO, the pages which are not related with redis, should run well.
i guess it miss try catch on redis

MikeAlhayek · 2024-07-24T20:28:10Z

I think if the Redis feature is enabled, it'll attempt to make a connection to the server which could be causing your issue. So I don't think you need to hit a page that uses IRedisService to encounter an issue with the connection string.

infofromca · 2024-07-24T20:37:05Z

The pages which use db as data source should keep working as normal.
and the page use redis should fail as expected.
in this way, the whole site can run silently and smoothly in my view.

MikeAlhayek · 2024-07-24T20:55:40Z

@infofromca

Based on what I can see, if you only enabled the Redis module, you should not get an exception. If the connection fails we log an error but we catch the exception so it should not break you app.

OrchardCore/src/OrchardCore.Modules/OrchardCore.Redis/Services/RedisDatabaseFactory.cs

Lines 38 to 55 in 84ae5cb

    
           _factories.GetOrAdd(options.Configuration, new Lazy<Task<IDatabase>>(async () => 
        
           { 
        
               try 
        
               { 
        
                   if (_logger.IsEnabled(LogLevel.Debug)) 
        
                   { 
        
                       _logger.LogDebug("Creating a new instance of '{name}'. A single instance per configuration should be created across tenants. Total instances prior creating is '{count}'.", nameof(ConnectionMultiplexer), _factories.Count); 
        
                   } 
        
                   return (await ConnectionMultiplexer.ConnectAsync(options.ConfigurationOptions)).GetDatabase(); 
        
               } 
        
               catch (Exception e) 
        
               { 
        
                   _logger.LogError(e, "Unable to connect to Redis."); 
        
                   return null; 
        
               } 
        
           })).Value;

The error you shared, what that displayed on the UI or you got that from the logs? I expect it to be in the logs only but the UI should not break.

infofromca · 2024-07-24T20:59:41Z

The UI was broken on home page. See the screenshot above

…

On Wed, Jul 24, 2024, 4:56 p.m. Mike Alhayek ***@***.***> wrote: @infofromca <https://github.com/infofromca> Based on what I can see, if you only enabled the Redis module, you should not get an exception. If the connection fails we log an error but we catch the exception so it should not break you app. https://github.com/OrchardCMS/OrchardCore/blob/84ae5cb0c8e0ec297a645f32b39695c3ea7003a3/src/OrchardCore.Modules/OrchardCore.Redis/Services/RedisDatabaseFactory.cs#L38-L55 The error you shared, what that displayed on the UI or you got that from the logs? I expect it to be in the logs only but the UI should not break. — Reply to this email directly, view it on GitHub <#16483 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACIVS33YFUJ7H7ODS74VBLZOAIGFAVCNFSM6AAAAABLMSZ5TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYHA4DENZVGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

infofromca · 2024-07-24T21:04:46Z

Ok. May be the home page called Iredisservice

…

On Wed, Jul 24, 2024, 4:59 p.m. guang zheng ***@***.***> wrote: The UI was broken on home page. See the screenshot above On Wed, Jul 24, 2024, 4:56 p.m. Mike Alhayek ***@***.***> wrote: > @infofromca <https://github.com/infofromca> > > Based on what I can see, if you only enabled the Redis module, you should > not get an exception. If the connection fails we log an error but we catch > the exception so it should not break you app. > > > https://github.com/OrchardCMS/OrchardCore/blob/84ae5cb0c8e0ec297a645f32b39695c3ea7003a3/src/OrchardCore.Modules/OrchardCore.Redis/Services/RedisDatabaseFactory.cs#L38-L55 > > The error you shared, what that displayed on the UI or you got that from > the logs? I expect it to be in the logs only but the UI should not break. > > — > Reply to this email directly, view it on GitHub > <#16483 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACIVS33YFUJ7H7ODS74VBLZOAIGFAVCNFSM6AAAAABLMSZ5TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYHA4DENZVGI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

infofromca · 2024-07-24T21:57:03Z

after double check , my home page use Article contentType which only includes those 4 parts :
Title Provides a Title for your content item.
Alias Provides a way to define custom aliases for content items.
Autoroute Provides a custom url for your content item.
HtmlBody Provides an HTML Body for your content item.

those 4 parts are not related with Redis I think.
but when I run the site, it hit redis stuff on the home page which cause the UI broken. reopen this issue.

infofromca · 2024-07-24T21:59:53Z

this is the code the home page hit:

private IDatabase? GetRedisDatabase()
{
    IDatabase? database = null;
    var redisService = _serviceProvider.GetService<IRedisService>();
    if (redisService != null)
    {
        database = redisService.Database;
    }

    return database;
}

MikeAlhayek · 2024-07-24T22:02:19Z

@infofromca I think there is something invalid on your end (somewhere).

I can't reproduce this issue in OC. I created the a new tenant using the blog recipe. I then configured Redis with wrong credentials, enabled Redis and Redis Cache. When the app started I do see the error you encountered in my logs, but the UI did not break as expected since we catch the connection exception.

infofromca · 2024-07-24T23:12:38Z

@MikeAlhayek Thanks, it happened on my custom layout. so close this

infofromca added the enhancement label Jul 24, 2024

hishamco added the needs author feedback label Jul 24, 2024

infofromca closed this as completed Jul 24, 2024

infofromca reopened this Jul 24, 2024

infofromca closed this as completed Jul 24, 2024

This was referenced Aug 1, 2024

Monthly community metrics report for 2024-07-01..2024-07-31 #16509

Closed

Monthly community metrics report for 2024-07-01..2024-07-31 SGuidone/OrchardCore#46

Open

Monthly community metrics report for 2024-07-01..2024-07-31 NinaRocket/OrchardCore#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Silently omit exception from Redis #16483

Silently omit exception from Redis #16483

infofromca commented Jul 24, 2024 •

edited by MikeAlhayek

Loading

hishamco commented Jul 24, 2024

infofromca commented Jul 24, 2024

hishamco commented Jul 24, 2024

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024 •

edited

Loading

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024 •

edited

Loading

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024 via email

infofromca commented Jul 24, 2024 via email

infofromca commented Jul 24, 2024

infofromca commented Jul 24, 2024 •

edited by MikeAlhayek

Loading

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024

Silently omit exception from Redis #16483

Silently omit exception from Redis #16483

Comments

infofromca commented Jul 24, 2024 • edited by MikeAlhayek Loading

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

hishamco commented Jul 24, 2024

infofromca commented Jul 24, 2024

hishamco commented Jul 24, 2024

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024 • edited Loading

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024 • edited Loading

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024 via email

infofromca commented Jul 24, 2024 via email

infofromca commented Jul 24, 2024

infofromca commented Jul 24, 2024 • edited by MikeAlhayek Loading

MikeAlhayek commented Jul 24, 2024

infofromca commented Jul 24, 2024

infofromca commented Jul 24, 2024 •

edited by MikeAlhayek

Loading

infofromca commented Jul 24, 2024 •

edited

Loading

infofromca commented Jul 24, 2024 •

edited

Loading

infofromca commented Jul 24, 2024 •

edited by MikeAlhayek

Loading