Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

459 - Generalize code implementation section in components #501

Merged
merged 38 commits into from
May 3, 2023
Merged

459 - Generalize code implementation section in components #501

merged 38 commits into from
May 3, 2023

Conversation

paulinea
Copy link
Member

@paulinea paulinea commented Apr 4, 2023

No description provided.

@paulinea paulinea linked an issue Apr 4, 2023 that may be closed by this pull request
Demo - Generalize code implementation section #459
Closed
@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

✅ Deploy Preview for ods-android canceled.

Name Link
🔨 Latest commit c9a7c33
🔍 Latest deploy log https://app.netlify.com/sites/ods-android/deploys/645275ac5a8f7b0008769dd3

@paulinea paulinea changed the title 459 - demo - generalize code implementation section 459 - Generalize code implementation section in components Apr 4, 2023
@paulinea paulinea force-pushed the 459-demo-generalize-code-implementation-section branch 2 times, most recently from 45bcbf5 to c99db59 Compare April 4, 2023 15:55
@paulinea paulinea force-pushed the 459-demo-generalize-code-implementation-section branch from a293522 to 26d7c51 Compare April 12, 2023 15:50
@paulinea paulinea requested a review from florentmaitre April 12, 2023 16:35
@paulinea paulinea marked this pull request as ready for review April 12, 2023 16:35
florentmaitre
florentmaitre reviewed Apr 19, 2023
View reviewed changes
app/src/main/java/com/orange/ods/app/ui/utilities/composable/CodeImplementation.kt Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/utilities/composable/CodeImplementation.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/utilities/composable/CodeImplementation.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/utilities/composable/CodeImplementation.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/snackbars/ComponentSnackbars.kt Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/progress/ProgressLinear.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/sliders/ComponentSliders.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/snackbars/ComponentSnackbars.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/snackbars/ComponentSnackbars.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/components/textfields/TextField.kt Outdated Show resolved Hide resolved
paulinea added 21 commits April 26, 2023 15:29
@paulinea
[#459] Factorize code implementation for banners and bottom navigatio…
4f10631 
…n components
@paulinea
[#459] Centralize code implementation management and generalize displ…
1f4d6b5 
…ay in components
@paulinea
[#459] Add OdsTopAppBar code implementation
c3b3a23
@paulinea
[#459] Fix code implementation for banner with image
f6226e0
@paulinea
[#459] Set all components screen scrollable
c11410a
@paulinea
[#459] Rename componentParameter into codeParameter
aa153b9
@paulinea
[#459] Manage code implementation display for menu exposed dropdown
6dfca45
@paulinea
[#459] Fix crash on components using ComponentLaunchContentColumn
f10f062
@paulinea
[#459] Change code implementation composables and display two steps f…
bcf1666 
…or snackbar component
@paulinea
[#459] Improve code implementation for text fields
a8eb9b5
@paulinea
[#459] Add modal drawer code implementation
d49fdc1
@paulinea
[#459] Rename Component by Composable in code implementation management
3ff3be0
@paulinea
[#459] Simplify code implementation usage
3617d6a
@paulinea
[#459] Add new code implementation for icon buttons
ebc9f3a
@paulinea
[#459] Update changelog
f9347ab
@paulinea
[#459] Remove unused import
dcae1eb
@paulinea
[#459] Add predefined parameters
0171286
@paulinea
[#459] Fix code implementation for snackbars
5b4be16
@paulinea
[#459] Remove blank line
5ce104a
@paulinea
[#459] Review: Remove invoke call
fcf10b5
@paulinea
[#459] Review: Rename ObjectParameter into ClassInstanceParameter
11274ae
@paulinea paulinea force-pushed the 459-demo-generalize-code-implementation-section branch from d00c511 to b2b2211 Compare April 26, 2023 14:03
paulinea and others added 13 commits April 26, 2023 16:03
@paulinea
[#459] Review: Remove useless file
9140e5c
@paulinea @florentmaitre
[#459] Review: Add comma between list elements
86de2e4
@paulinea @florentmaitre
[#459] Review: Simplify and improve code implementation
823c885
@paulinea @florentmaitre
[#459] Review: Add condition to display divider in code implementatio…
6d8d2d0 
…n section
@paulinea @florentmaitre
[#459] Review: Replace mutableListOf by buildList
f8db786
@paulinea @florentmaitre
[#459] Review: Fix regression by adding a recipe image for avatar
1392dc3
@paulinea @florentmaitre
[#459] Review: Use StringRepresentationParameter for enums
202393d
@paulinea @florentmaitre
[#459] Review: Add FloatParameter to manage float display in code imp…
f287441 
…lementation

Use it in slider component screen
@paulinea @florentmaitre
[#459] Review: Rename ComposableCode by FunctionCallCode
b1a9064
@paulinea @florentmaitre
[#459] Review: Remove useless call to customizationState
0f55437
@paulinea @florentmaitre
[#459] Review: Add OdsComponentApi annotation on some components to b…
e5e03e6 
…e able to use their names in code implementation sections
@paulinea @florentmaitre
[#459] Review: Add code implementation for chips
2aa0992
@florentmaitre
[#459] Review: Add code implementation for filter chips
c9a7c33
@florentmaitre florentmaitre force-pushed the 459-demo-generalize-code-implementation-section branch from 6797fac to c9a7c33 Compare May 3, 2023 14:54
@florentmaitre florentmaitre merged commit afc75f8 into develop May 3, 2023
@florentmaitre florentmaitre deleted the 459-demo-generalize-code-implementation-section branch May 3, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentmaitre florentmaitre florentmaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo - Generalize code implementation section
2 participants
@paulinea @florentmaitre