Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OdsTopAppBar customization is not applied #747

Closed
paulinea opened this issue Dec 13, 2023 · 2 comments · Fixed by #748
Closed

OdsTopAppBar customization is not applied #747

paulinea opened this issue Dec 13, 2023 · 2 comments · Fixed by #748
Labels
🐞 bug Something isn't working 📱 demo app 👌 OK PO

Comments

@paulinea
Copy link
Member

No description provided.

@paulinea paulinea added 🐞 bug Something isn't working 📱 demo app labels Dec 13, 2023
@paulinea paulinea self-assigned this Dec 13, 2023
paulinea added a commit that referenced this issue Dec 13, 2023
@paulinea
[#747] Set customizable top app bar for top app bar regular and large
91e00dd
paulinea added a commit that referenced this issue Dec 13, 2023
@paulinea
[#747] Update changelog
0048168
@paulinea paulinea linked a pull request Dec 13, 2023 that will close this issue
747 - Fix OdsTopAppBar and OdsLargeTopAppBar customization through the bottom sheet #748
Merged
florentmaitre pushed a commit that referenced this issue Dec 15, 2023
@paulinea @florentmaitre
[#747] Set customizable top app bar for top app bar regular and large
4308e2c
florentmaitre pushed a commit that referenced this issue Dec 15, 2023
@paulinea @florentmaitre
[#747] Update changelog
746b034
@paulinea paulinea removed their assignment Dec 15, 2023
@B3nz01d
Copy link
Collaborator

B3nz01d commented Jan 25, 2024

@paulinea remind me what is to be tested?

@paulinea
Copy link
Member Author

@paulinea remind me what is to be tested?

@B3nz01d This was a bug introduced by the previous release. The top app bars were no more customizable through the bottom sheet. It has been fixed in this PR.

@B3nz01d B3nz01d removed their assignment Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 📱 demo app 👌 OK PO
Projects
None yet
Milestone
No milestone
2 participants
@paulinea @B3nz01d