Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: XML version of buttons components not working when forced on dark/light #656

Closed
1 task done
B3nz01d opened this issue Oct 4, 2023 · 0 comments · Fixed by #786
Closed
1 task done

[Bug]: XML version of buttons components not working when forced on dark/light #656

B3nz01d opened this issue Oct 4, 2023 · 0 comments · Fixed by #786
Labels
🐞 bug Something isn't working ⚛️ Component 📗 ods library 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 4, 2023

Prerequisites

Your test device

any

OS Version

any

App version

v0.15 (273)

Describe the issue

the xml version of the button highest high and medium emphasis all have issues in the forced dark mode or forced light mode
implementation.

  • the button hight the groing
  • or there is a white or black background
  • or the button is fully white of black whith the text not visible

Expected Behavior

should see the same behavior as in compose
@B3nz01d B3nz01d self-assigned this Oct 4, 2023
@B3nz01d B3nz01d mentioned this issue Oct 4, 2023
Closed
@paulinea paulinea changed the title [Bug]: Bug Summary [Bug]: XML version of buttons components not working when forced on dark/light Oct 19, 2023
@paulinea paulinea mentioned this issue Jan 19, 2024
Open
@paulinea paulinea assigned paulinea and unassigned florentmaitre Jan 19, 2024
paulinea added a commit that referenced this issue Jan 19, 2024
@paulinea
[#656] Remove Surface from OdsTheme and add it in Preview
b7d4a8b
paulinea added a commit that referenced this issue Jan 19, 2024
@paulinea
[#656] Update changelog
9a0cf89
@paulinea paulinea linked a pull request Jan 19, 2024 that will close this issue
656 - Fix XML version of buttons not working when forced on dark or light #786
Merged
florentmaitre pushed a commit that referenced this issue Jan 25, 2024
@paulinea @florentmaitre
[#656] Remove Surface from OdsTheme and add it in Preview
b9a3989
florentmaitre pushed a commit that referenced this issue Jan 25, 2024
@paulinea @florentmaitre
[#656] Update changelog
14844a4
@paulinea paulinea assigned B3nz01d and unassigned paulinea Jan 25, 2024
@B3nz01d B3nz01d removed their assignment Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working ⚛️ Component 📗 ods library 👌 OK PO
Projects
None yet
Milestone
No milestone
3 participants
@florentmaitre @paulinea @B3nz01d