Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Button page to clarify the OdsButtonStyle options #339

Closed
B3nz01d opened this issue Nov 23, 2022 · 0 comments · Fixed by #365
Closed

Update the Button page to clarify the OdsButtonStyle options #339

B3nz01d opened this issue Nov 23, 2022 · 0 comments · Fixed by #365
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Nov 23, 2022

The button pages for Highest, High and Functionnal need to be update so that:

  • take out the "style" option in the bottom sheet
  • make sure the page nav bar title is coherent with the button shown
  • take out the "Primary" and "Default" page title
  • change the code function name font to "courrier"
  • add a section "code implementation" to describe how to use the component objects and it's parameters
@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated 📱 demo app ⚛️ Component labels Nov 23, 2022
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Dec 5, 2022
@paulinea paulinea self-assigned this Dec 5, 2022
paulinea added a commit that referenced this issue Dec 6, 2022
@paulinea
[#339] Display code implementation for buttons
cd5f2f7
@paulinea paulinea linked a pull request Dec 6, 2022 that will close this issue
339 - Update buttons to display code implementation and remove styles from contained buttons customization #365
Merged
paulinea added a commit that referenced this issue Dec 6, 2022
@paulinea
[#339] Remove useless strings
645ece5
paulinea added a commit that referenced this issue Dec 7, 2022
@paulinea
[#339] Display code implementation for buttons
ab1ae1a
paulinea added a commit that referenced this issue Dec 7, 2022
@paulinea
[#339] Remove useless strings
f515e13
paulinea added a commit that referenced this issue Dec 7, 2022
@paulinea
[#339] Update changelog
23c61cf
paulinea added a commit that referenced this issue Dec 15, 2022
@paulinea
[#339] Review: Add comma at the end of technical text
b5b61c4
florentmaitre pushed a commit that referenced this issue Dec 15, 2022
@paulinea @florentmaitre
[#339] Display code implementation for buttons
7c8545d
florentmaitre pushed a commit that referenced this issue Dec 15, 2022
@paulinea @florentmaitre
[#339] Remove useless strings
9ef50fe
florentmaitre pushed a commit that referenced this issue Dec 15, 2022
@paulinea @florentmaitre
[#339] Update changelog
8248126
florentmaitre pushed a commit that referenced this issue Dec 15, 2022
@paulinea @florentmaitre
[#339] Review: Add comma at the end of technical text
9f2685a
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned paulinea Dec 16, 2022
@B3nz01d B3nz01d removed their assignment Jan 3, 2023
@afrahB afrahB removed their assignment Jan 4, 2023
@mccart77 mccart77 removed their assignment Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
4 participants
@paulinea @B3nz01d @mccart77 @afrahB