Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Text Fields page #221

Closed
4 tasks
B3nz01d opened this issue Jul 7, 2022 · 3 comments · Fixed by #251
Closed
4 tasks

Update the Text Fields page #221

B3nz01d opened this issue Jul 7, 2022 · 3 comments · Fixed by #251

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Jul 7, 2022

Text Fields

Requirement

As a developer reviewing the mobile demo app
I want to be able to use the demo app
So That it reflects the various text fields options available

General description

  • The following variants should be added in and be editable: (To Be Checked with Android)
    • Text Field
    • Secure Field
    • Text Editor (multiline)
    • Text Input Autocapitalization

Reference links

@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated user story An agile user story request 📱 demo app ⚛️ Component 💧 basic labels Jul 7, 2022
@B3nz01d
Copy link
Collaborator Author

B3nz01d commented Jul 7, 2022

@B3nz01d ;) This card would serv as the Component > Text Selection completion as the DSM will be updated to show only one "Text Fields" component to gather Text Filed / Selection / Edit Menu

@B3nz01d B3nz01d changed the title Update the Text Field page Update the Text Fields page Jul 7, 2022
@paulinea
Copy link
Member

paulinea commented Aug 2, 2022

@B3nz01d We have to clarify this issue cause text selection is not a text field. Not very clear for us.

@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Aug 23, 2022
@paulinea paulinea self-assigned this Aug 23, 2022
@B3nz01d
Copy link
Collaborator Author

B3nz01d commented Aug 23, 2022

About the DSM Text field page: https://system.design.orange.com/0c1af118d/p/483f94-text-fields/

We have gathered the following clarifications based on the latest DSM updates:

  • the technical level of the jetpack library is providing 2 separate functions that either show the filled text field and the outlined text field. Therefore we need to keep this first level clearly visible for the developers.
  • With the need to show filled or outlined AND text/secured/multiple lines we proposed the following structure for the new dev:
    • Filled
      • text fields : options for the bottom sheet
      • tab text field:
        • Input Type: Single line / Multi line / Text Area
        • State: Default / Error / Disabled
        • Leading icon: Toggle
        • Trailing: None / Icon / Text
        • Character Counter: Toggle
      • tab keyboard options:
        • type: text / Number / Decimal / Phone / Url / Email
        • Capitalization: toggle
        • Action: None / Default / Go / Search / Send / Previous / Next / Done
      • Password filed : options for the bottom sheet:
        • State : Default / Error / Disabled
        • Text password / number password
        • Trailing Visualization icon
        • Keyboard: Text Password / Number Password
    • Outlined text field
      • text fields - same as previously described
      • Password filed - same as previously described

image

@mccart77 we have looked at this request and have found the following question:

  • Is the previously described proposition OK for you?
  • In the DSM we see that there is the option of showing or hiding the label in the fields. Right now and by default in android jetpack the label is always visible. Do we need to show an example of the label hidden or do you consider that the design should always show a label?

paulinea added a commit that referenced this issue Aug 25, 2022
@paulinea paulinea linked a pull request Aug 25, 2022 that will close this issue
paulinea added a commit that referenced this issue Aug 25, 2022
paulinea added a commit that referenced this issue Aug 25, 2022
paulinea added a commit that referenced this issue Sep 6, 2022
paulinea added a commit that referenced this issue Sep 6, 2022
paulinea added a commit that referenced this issue Sep 6, 2022
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned paulinea Sep 6, 2022
@B3nz01d B3nz01d removed their assignment Sep 8, 2022
paulinea added a commit that referenced this issue Sep 8, 2022
@afrahB afrahB removed their assignment Sep 23, 2022
@mccart77 mccart77 removed their assignment Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants