Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODS-Component - App Bar Standard #105

Closed
4 tasks
B3nz01d opened this issue Apr 14, 2022 · 0 comments · Fixed by #244
Closed
4 tasks

ODS-Component - App Bar Standard #105

B3nz01d opened this issue Apr 14, 2022 · 0 comments · Fixed by #244
Labels
💧 basic ⚛️ Component 👌 OK Accessibility 👌 OK Design 👌 OK PO styled user story An agile user story request

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Apr 14, 2022 •
edited
Loading

Standard App Bar

Requirement

As a developer
I want to insert a Standard App Bar
So That I will get this ready to use component compatible with Orange design specifications and a11y requirements

DSM reference

General description

Component

For the component description please refer to the DSM updates

App Page

the page will propose to the user to describe the component and allow to see the implementation in action of the variants.

UI specifications

Anatomy

Component

For the component Anatomy please refer to the DSM updates

App Page

ScreenShot195

  • title: "App Bar"
  • image: xxx.jpg
  • Text: intro text in the DSM
  • Core field: The user will be able to select from the various optional element to display in the App Bar
    • Checkbox: Menu
    • Radio buttons:
      • no icons
      • 1 icon
      • multiple icons

Variants

There are 2 variants:

  • Standard App Bar
  • Extended App Bar (not dealt within this User Story

States

  • NA

Internationalization

  • NA

UX specifications

Interaction

  • All:
    • The user is able to select a text using the default OS behavior
  • Touch:
    • Nothing Specific
  • Keyboard:
    • Nothing specific

Animations

  • default OS animation

Accessibility

Visual Accessibility

  • taken into account within the design creation process

Usage Accessibility

  • (?) Focus order - NA
  • (?) Focus loss expected behavior - NA
  • (?) Screen Reader - default OS behavior

Technical specifications

Implementation tasks

  • Task 1
  • Task 2

Related tasks

  • Task 1
  • Task 2
@B3nz01d B3nz01d added 🔍 triage A new issue that needs to be treated user story An agile user story request ⚛️ Component 💧 basic labels Apr 14, 2022
@B3nz01d B3nz01d self-assigned this Apr 14, 2022
@B3nz01d B3nz01d added the styled label Apr 14, 2022
@B3nz01d B3nz01d removed their assignment Apr 15, 2022
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Aug 2, 2022
@paulinea paulinea self-assigned this Aug 2, 2022
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] [#105] Add app bars top component structure
b3f5026
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Rearrange code to be able to change the top app bar dynamically
a28a7e6
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Allow to customize a regular top app bar
88c0111
@paulinea paulinea linked a pull request Aug 4, 2022 that will close this issue
105 - ods component - app bar standard #244
Merged
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Add app bars top component structure
ce287aa
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Rearrange code to be able to change the top app bar dynamically
18c79d1
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Allow to customize a regular top app bar
f330f8f
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Update changelog
747f596
paulinea added a commit that referenced this issue Aug 4, 2022
@paulinea
[#105] Update top app bar documentation
fefa3bc
paulinea added a commit that referenced this issue Aug 5, 2022
@paulinea
[#105] Update top app bar documentation
4c3a5aa
paulinea added a commit that referenced this issue Aug 5, 2022
@paulinea
[#105] Iterate on app bar top demo overflow actions
32b0817 
Use strings for app bar top actions
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Remove useless annotations
0649c43
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Use default OdsDemoTopAppBarState.configuration for de…
9547896 
…fault values
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Move minActionCount and maxActionCount in AppBarTopCus…
6345d46 
…tomizationState
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Remove useless string
615dcf0
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Remove extra spaces
edb8857
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Simplify expression
6c4c834
paulinea added a commit that referenced this issue Aug 22, 2022
@paulinea
[#105] Review: Use shorter expression
4e3c454
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Allow to customize a regular top app bar
be0e4c0
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Update changelog
803a829
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Update top app bar documentation
c4e24ba
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Iterate on app bar top demo overflow actions
fb3b310 
Use strings for app bar top actions
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Remove useless annotations
925114e
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Use default OdsDemoTopAppBarState.configuration for de…
8b27b79 
…fault values
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Move minActionCount and maxActionCount in AppBarTopCus…
1a53941 
…tomizationState
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Remove useless string
e3be777
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Remove extra spaces
0a9372b
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Simplify expression
dc403a5
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Use shorter expression
da561d8
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Rename "AppBarTop" in "TopAppBar" everywhere except fo…
15e1d1d 
…r package name
florentmaitre pushed a commit that referenced this issue Aug 30, 2022
@paulinea @florentmaitre
[#105] Review: Fix top app bar component illustration background color
06711e7
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned paulinea Aug 30, 2022
@mccart77 mccart77 removed their assignment Aug 31, 2022
@B3nz01d B3nz01d removed their assignment Aug 31, 2022
@afrahB afrahB removed their assignment Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💧 basic ⚛️ Component 👌 OK Accessibility 👌 OK Design 👌 OK PO styled user story An agile user story request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

105 - ods component - app bar standard Orange-OpenSource/ods-android
4 participants
@paulinea @B3nz01d @mccart77 @afrahB